Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework using local nanoCLR DLL #2600

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Major simplification of passing a path for the DLL or defaulting to local instance.
  • Simplification on calling ExecuteCommandProcessor and ClrInstanceOperationsProcessor processors.

Motivation and Context

  • Previous approach was too convoluted and was failing on certain use cases.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

- Major simplification of passing a path for the DLL or defaulting to local instance.
- Simplification on calling ExecuteCommandProcessor and ClrInstanceOperationsProcessor processors.
@josesimoes josesimoes added the Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds label Mar 15, 2023
@josesimoes josesimoes merged commit b691232 into nanoframework:main Mar 15, 2023
@josesimoes josesimoes deleted the improve-local-clr branch March 15, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants