Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev evolving #109

Closed
wants to merge 2 commits into from
Closed

Dev evolving #109

wants to merge 2 commits into from

Conversation

CayenneMatt
Copy link
Collaborator

Description

To small changes:

  1. Caught a case where a function needed redz as an argument. Not sure if it got overwritten or never made it into the last PR, but it should definitely be in there.
  2. Added another except statement to host_relations.py to catch a ValueError coming from reshaping redz when it didn't need to

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

@CayenneMatt
Add redz=redz as argument to dmstar_dmbh
6560e58 
Add redz=redz as argument to dmstar_dmbh in line 358 for use in evolving version of mmbulge function
@CayenneMatt
Add except statement to mbh_from_mbulge
dd0c7b7 
Add except ValueError statement to mbh_from_mbulge (within MMBulge_Redshift) on line 848 to catch another instance where redz doesn't need to be reshaped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CayenneMatt