Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logger not works before finishing parse oldconf. #713

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix the logger not works before finishing parse oldconf. #713

merged 1 commit into from
Oct 23, 2023

Conversation

wanghaEMQ
Copy link
Member

No description provided.

@wanghaEMQ wanghaEMQ requested review from JaylinYu, alvin1221, RanMaoyi, OdyWayne and xinyi-xs and removed request for JaylinYu October 23, 2023 08:34
OdyWayne
OdyWayne approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@OdyWayne OdyWayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@JaylinYu JaylinYu merged commit 11019a8 into main Oct 23, 2023
13 of 15 checks passed
@JaylinYu JaylinYu deleted the wangha/dev branch October 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RanMaoyi RanMaoyi RanMaoyi approved these changes

@OdyWayne OdyWayne OdyWayne approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

@alvin1221 alvin1221 Awaiting requested review from alvin1221

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wanghaEMQ @RanMaoyi @OdyWayne @JaylinYu @xinyi-xs