Memory leak fixes #2001
Merged
Memory leak fixes #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destruct_context() is an arch-specific function that undoes what init_context_machine() does; failure to call this function before deallocating a kernel context leaks the memory allocated by init_context_machine().
A process context retrieved via a get_process_context() call has an initial refcount value of 1; if the refcount is not decremented in the relevant completion closure, the context will never be returned to the free list, nor deallocated. This change adds a context field to the aio_complete and aio_eventfd_complete closures, so that the process context can be properly released.
A process context retrieved via a get_process_context() call has an initial refcount value of 1; if the refcount is not decremented when the async operations triggered by io_uring_enter() are completed, the context will never be returned to the free list, nor deallocated. This change adds a context field to the iour_rw_complete and iour_close_complete closures, so that the process context can be properly released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes memory leaks that have been discovered while load-testing mysql with HammerDB (#1999).