Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -enable-kvm #587

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Fix -enable-kvm #587

merged 1 commit into from
Mar 12, 2019

Conversation

mkhon
Copy link
Contributor

@mkhon mkhon commented Mar 12, 2019 •
edited
Loading

  1. Per "3.1.1 Driver Requirements: Device Initialization":
  • virtqueues (and interrupts) should be configured before setting DRIVER_OK status bit
  • the driver MUST NOT notify the device before setting DRIVER_OK

This fixes virtio-blk and virtio-scsi virtqueue interrupts in -enable-kvm mode

  1. Per "4.1.5.1.3.2 Driver Requirements: MSI-X Vector Configuration":
    After mapping an event to vector, the driver MUST verify success by reading
    the vector field value.

@mkhon
1) Per "3.1.1 Driver Requirements: Device Initialization":
86106c5 
  - virtqueues (and interrupts) should be configured before setting DRIVER_OK status bit
  - the driver MUST NOT notify the device before setting DRIVER_OK

This fixes virtio-blk and virtio-scsi virtqueue interrupts in -enable-kvm mode

2) Per "4.1.5.1.3.2 Driver Requirements: MSI-X Vector Configuration":
After mapping an event to vector, the driver MUST verify success by reading
the vector field value.
@mkhon mkhon requested a review from wjhun March 12, 2019 21:05
@mkhon mkhon mentioned this pull request Mar 12, 2019
Closed
wjhun
wjhun approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@wjhun wjhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for finally nailing this one down.

This was referenced Mar 12, 2019
Merged
Closed
@mkhon mkhon merged commit 3e082b0 into master Mar 12, 2019
@mkhon mkhon deleted the fix-kvm-virtio branch March 12, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhun wjhun wjhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkhon @wjhun