Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test functions for every mapper in separate package #79

Closed
mortenwh opened this issue Jul 15, 2014 · 6 comments
Closed

Write test functions for every mapper in separate package #79

mortenwh opened this issue Jul 15, 2014 · 6 comments
Assignees
Milestone

Comments

@mortenwh
Copy link
Contributor

We need to make proper tests for all mappers. There should probably be two tests for each - one with a given mapperName and one without. Test data can be added to the ftp-server like the present asar-file.
This probably don't need to be in its own branch, as nansat is independent of tests and we will continuously have to add new ones.

@asumak
Copy link
Contributor

asumak commented Jul 18, 2014

f4f9e9a : I created some mapper test functions:
asar, asterL1a, cosmoskymed, hirlam, landsat, meris, modisL1, ncep, generic, radarsat2

Can anyone make other mapper test functions?
Left mapper tests are follows:
aapp_l1b, aapp_l1c, amsr2_l3, ascat_nasa, case2reg, geostationary, globcolour_l3b, globcolour_l3m, goci_l1, hirlam_wind_netcdf, kmss, metno_hires_seaice, etno_local_hires_seaice, obpg_l2, obpg_l3, ocean_productivity, opendap, pathfinder52, s1a_l2, smos_mat, viirs_l1

@mortenwh mortenwh changed the title Write test functions for every mapper Write test functions for every mapper in separate package Sep 11, 2014
@mortenwh
Copy link
Contributor Author

Would it work to have a mapper_tests package in the root of the nansat repos and a tests module as nansat.tests which tests the core functionality of nansat (like tutorial now)? Could Travis CI then only run nansat.tests whereas we as the developers could test the mappers with the mapper_tests package?

@akorosov
Copy link
Member

@neothemachine , I removed mapper_tests from packages in setup.py but nosetests still want;s to test the mappers and fails: https://travis-ci.org/nansencenter/nansat/builds/36542717
Why is that? How to prevent from testing in mapper_tests ?

akorosov added a commit that referenced this issue Sep 29, 2014
@akorosov
Copy link
Member

@neothemachine , Ok, it seems I figured it out ;)
https://travis-ci.org/nansencenter/nansat/builds/36544513

akorosov added a commit that referenced this issue Sep 29, 2014
akorosov added a commit that referenced this issue Sep 29, 2014
akorosov added a commit that referenced this issue Sep 29, 2014
akorosov added a commit that referenced this issue Sep 29, 2014
akorosov added a commit that referenced this issue Sep 29, 2014
@akorosov
Copy link
Member

Closed in 8fc536d
mapper_tests are moved into project root and excluded from nosetests and from installable packages; nansat/tests/ replace tutorial. More tests to be added in #91

@akorosov
Copy link
Member

akorosov commented Oct 6, 2014

There is only one function for download in the DataForTestingMappers mappers. It downloads files into subdirs of the download dir recreating the structure on the FTP server.
There are only two functions fortesting all the mappers. They are called for each downloaded file (either with specification of the mapper, or without) in such a way that each call is considered as a separate test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants