Issue345 remove obsolete #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage has decrease in % and only because the total number of lines has decreased. All tests pass! |
korvinos
approved these changes
Jul 17, 2018
nansat/domain.py
Outdated
| @@ -875,7 +853,3 @@ def reproject_gcps(self, srs_string=''): | |||
| srs_string = '+proj=stere +datum=WGS84 +ellps=WGS84 +lat_0=%f +lon_0=%f +no_defs' \ | |||
| % (np.nanmedian(lat), np.nanmedian(lon)) | |||
| self.vrt.reproject_GCPs(srs_string) | |||
There was a problem hiding this comment.
I am not sure that it is relevant for this particular PR. However, why we refactored the reproject_gcps name at the Domain class but left it reproject_GCPs in the VRT class?
There was a problem hiding this comment.
Good observation. I'll change that as well.
|
@akorosov , Does coveralls fail due to decreasing of the coverage? |
|
No, as I said before the coevrage in lines remained the same. But number of lines decreased. Hence percentage increases. Statistics... :) |
|
I am so sorry :(, but I missed that you forgot to change subversion. I'm going to merge the PR just after that |
akorosov
added a commit
that referenced
this pull request
Jul 18, 2018
* #251 close issue * add dev * #272 update conventions * #272 account for comment in #239 * #272 update conventions * #272 update conventions * #264 extend docstring * #91 add tests for VRT * #91 increase test coverage for node * #91 fix according to PR comments * #212 remove cfunits; setup: move numpy, gdal to REQS * #212 remove check of numpy and gdal * #313 add Vagrantfile and provisioning * set libnetcdf version for Vagrant * #331: Modified nansat_test_base.py * #331: clean up in nansat_test_base.py * #329: Added section following suggestions in issue description * Added info about forking and noted that hotfix is generally done by team members * #329: more info on handling forks * #329: Changed text in conventions according to reviews * #336 update docs * Update release_nansat.rst * Update release_nansat.rst * Issue325 mock missing install nansat readme (#340) * add .vagrant to gitignore * "#325: README.rst new install proc. added new Test section (nose mock)" * "#325: README.rst spelling" * Updated README.rst according to comments and, changed section 'Usage' to 'Activate and work in the nansat environment' (too long?), and, also switched the link to the "wiki" page in the bottom to a link to Read the Docs! * empty commit to fix failed Travis CI check? * travis.yml: libnetcdf no pinning * #340: Modified installation.rst according to comments * Added to conda create missing: nansat * Developed method returns border geometry in geojson format * Developed for the geometry to geojson method * #345 remove obsolote function parameters and NansatFutureWarning calls * #345 move basemap checks to test_tools * #345 #347 fix reproject_GCPs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@korvinos , can you have a look please?