Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donot change case #107

Merged
merged 35 commits into from
Sep 26, 2017
Merged

Donot change case #107

merged 35 commits into from
Sep 26, 2017

Conversation

naokazuterada
Copy link
Owner

@naokazuterada naokazuterada commented Sep 24, 2017

@jonasbn Hi, good evening from Japan.

I've implemented two features during this weekend.
Could you check my English as usual? And please let me know if there are anything wired.

I always appreciate your kindness. Thank you.

CHANGES

* master:
  Fill all lang of block quote
  Remove single quote in 'Attributes' table
  Fix value format
  - Fix CHANGELOG.md - Add messages for 2.5.0
  Add tests for list_bullets
  Add 'Customizable list bullets in TOC' section on README.
  Add 'default_list_bullets' #41

# Conflicts:
#	MarkdownTOC.py
#	MarkdownTOC.sublime-settings
- Cleanup global consts
- Fix don't remove image in codeblock
@codecov
Copy link

codecov bot commented Sep 24, 2017

Codecov Report

Merging #107 into master will increase coverage by 1.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   92.11%   93.25%   +1.13%     
==========================================
  Files           1        1              
  Lines         279      326      +47     
==========================================
+ Hits          257      304      +47     
  Misses         22       22
Impacted Files Coverage Δ
MarkdownTOC.py 93.25% <100%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a9767...f57428a. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 24, 2017

Coverage Status

Coverage increased (+1.1%) to 93.252% when pulling de351f8 on donot-change-case into f7a9767 on master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes:

  1. "Do not change case" should be changed to "Preserve case"
  2. "Maintain the images in headings" should be changed to "Preserve images in headings"
  3. You made one minor grammatical mistake in:

"If you don't want to removing images in headings, please set remove_image to false."

It should read:

"If you do not want to remove images in headings, please set remove_image to false."

If you accept my proposal in 2. I would rephrase it to:

"If you want to preserve images in headings, set remove_image to false."

It looks good and great work with the new features.

@naokazuterada
Copy link
Owner Author

naokazuterada commented Sep 25, 2017

Hi, @jonasbn. Thank you a lot for your proposal. It's very helpful.

Please check again, and approve it if there are nothing else.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 93.252% when pulling f57428a on donot-change-case into f7a9767 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 93.252% when pulling f57428a on donot-change-case into f7a9767 on master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@naokazuterada naokazuterada merged commit f57428a into master Sep 26, 2017
@naokazuterada naokazuterada deleted the donot-change-case branch September 26, 2017 10:53
@naokazuterada
Copy link
Owner Author

@jonasbn Thank you!

@jonasbn
Copy link
Collaborator

jonasbn commented Sep 26, 2017

Followed up with some primitive promotion https://twitter.com/jonasbn/status/912632340890968064

@naokazuterada
Copy link
Owner Author

@jonasbn Wow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants