-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donot change case #107
Donot change case #107
Conversation
* master: Fill all lang of block quote Remove single quote in 'Attributes' table Fix value format - Fix CHANGELOG.md - Add messages for 2.5.0 Add tests for list_bullets Add 'Customizable list bullets in TOC' section on README. Add 'default_list_bullets' #41 # Conflicts: # MarkdownTOC.py # MarkdownTOC.sublime-settings
- Cleanup global consts
This reverts commit 2ac5d9f.
- Fix don't remove image in codeblock
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 92.11% 93.25% +1.13%
==========================================
Files 1 1
Lines 279 326 +47
==========================================
+ Hits 257 304 +47
Misses 22 22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes:
- "Do not change case" should be changed to "Preserve case"
- "Maintain the images in headings" should be changed to "Preserve images in headings"
- You made one minor grammatical mistake in:
"If you don't want to removing images in headings, please set remove_image
to false
."
It should read:
"If you do not want to remove images in headings, please set remove_image
to false
."
If you accept my proposal in 2. I would rephrase it to:
"If you want to preserve images in headings, set remove_image
to false
."
It looks good and great work with the new features.
Hi, @jonasbn. Thank you a lot for your proposal. It's very helpful. Please check again, and approve it if there are nothing else. |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@jonasbn Thank you! |
Followed up with some primitive promotion https://twitter.com/jonasbn/status/912632340890968064 |
@jonasbn Wow, thanks! |
@jonasbn Hi, good evening from Japan.
I've implemented two features during this weekend.
Could you check my English as usual? And please let me know if there are anything wired.
I always appreciate your kindness. Thank you.
CHANGES
remove_image
parameter. Ref: Allow to include images in titles #43lowercase
parameter. Ref: Don't change case in Auto-link feature #40