Update contributing #121

naokazuterada · 2018-03-11T07:37:02Z

@jonasbn , hello again!

It's been a long time, but this PR is an measure to deal with the problem we suffered before. #95 (comment)

I also added the issue template for common types of issues.

Please take a look whenever you have a time.

Thanks!

* master: (144 commits) Fix typo Modify travis.yml according to https://github.com/randy3k/UnitTesting-example/blob/master/.travis.yml Recover sudo Change url Remove 'sudo' Sudo-enabled Trusty images Rename and modify message format Preparation for v2.7.1 Allow single quoted value Fix string replacement Regex matching setting tags fixed Dropped dependency on bs4 sucrificing tag-defined id_replacements Update messages.json - Update change logs - Add message Add 'Link Prefix' on README Specify codeblock syntax Use double quote in string value Fix error Add link_prefix test Add 'link_prefix' ...

codecov · 2018-03-11T07:40:04Z

Codecov Report

Merging #121 into master will increase coverage by 1.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   93.25%   95.16%   +1.91%     
==========================================
  Files           1        1              
  Lines         326      455     +129     
==========================================
+ Hits          304      433     +129     
  Misses         22       22

Impacted Files	Coverage Δ
MarkdownTOC.py	`95.16% <0%> (+1.91%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e8952...d867a75. Read the comment docs.

coveralls · 2018-03-11T07:40:26Z

Coverage remained the same at 93.252% when pulling d867a75 on update-contributing into 97e8952 on master.

jonasbn · 2018-03-11T19:42:35Z

Hi @naokazuterada

I will have a look ASAP.

jonasbn

Hi @naokazuterada, here are some suggestions for minor improvements to the language. Please pick the ones you like if any.

jonasbn · 2018-03-19T19:37:17Z

.github/CONTRIBUTING.md

@@ -4,12 +4,24 @@ These are the guidelines for contributing to this repository.

 ## Issues

-File an issue if you think you've found a bug. Please describe
+Please follow the each template by the type of your issue.


"Please follow the each template by the type of you issue." should read: "Please use the template for your type of issue"

jonasbn · 2018-03-19T19:38:10Z

.github/CONTRIBUTING.md

+
+### Way of operation
+
+1. The contributors will `Close` these Issues or PR


Do you mean maintainers?

Suggestion: "The maintainers will Close the issue or PR"

Thanks, you are right.

jonasbn · 2018-03-19T19:41:18Z

.github/CONTRIBUTING.md

+
+1. The contributors will `Close` these Issues or PR
+    1. Not accepted feature request
+        - Add `wontfix` label


Add the wontfixlabel

jonasbn · 2018-03-19T19:42:16Z

.github/CONTRIBUTING.md

+1. The contributors will `Close` these Issues or PR
+    1. Not accepted feature request
+        - Add `wontfix` label
+    2. Not obvious and Not responding


Suggestion: "Not clear or unresponsive"

jonasbn · 2018-03-19T19:43:08Z

.github/CONTRIBUTING.md

+    1. Not accepted feature request
+        - Add `wontfix` label
+    2. Not obvious and Not responding
+        - Not obvious: Problem is not obvious, or not reproduced.


Suggestion: "Not clear: Problem is not obvious or not reproducible"

jonasbn · 2018-03-19T19:49:07Z

.github/ISSUE_TEMPLATE.md

+# What actually occurred
+
+# What version of the involved component


Suggestion: "What was the version of the involved component"

jonasbn · 2018-03-19T19:49:39Z

.github/ISSUE_TEMPLATE/feature.md

+You should label `feature-request`.
+
+
+If your purpose is different, please visit following links.


Suggestion: "If you issue is not a feature request, please visit one of the following links."

jonasbn · 2018-03-19T19:50:08Z

.github/ISSUE_TEMPLATE/question.md

+
+Template: QUESTION
+
+This is an issue for a feature request.


Suggestion: "This is a template for a general question"

Oh... sorry, 😓

jonasbn · 2018-03-19T19:50:26Z

.github/ISSUE_TEMPLATE/feature.md

+
+Template: FEATURE REQUEST
+
+This is an issue for a feature request.


Suggestion: Replace "issue" with "template"

jonasbn · 2018-03-19T19:51:09Z

.github/ISSUE_TEMPLATE/question.md

+You should label `question`.
+
+
+If your purpose is different, please visit following links.


Suggestion: "If you issue is not a question, please visit one of the following links."

@jonasbn

Thank you for @jonasbn !

naokazuterada · 2018-03-20T13:57:28Z

@jonasbn Thank you so much!!

I correct almost everything you pointed out.
(I thought this might be a miss type)

I'm so appreciate for compensating for my lack of English skills! Very helpful!

naokazuterada added 6 commits June 10, 2017 17:19

Cleanup: Remove trailing white spaces

13ca16b

Add 'Useful Tools'

eb6f304

WIP: Add 'Way of operation' section

5651b5c

Update CONTRIBUTING.md

5a29306

Add some issue_template files

2cc9301

naokazuterada requested a review from jonasbn March 11, 2018 07:37

jonasbn requested changes Mar 19, 2018

View reviewed changes

Correct the incorrect or not natural English expressions

d867a75

Thank you for @jonasbn !

naokazuterada merged commit d867a75 into master Mar 20, 2018

naokazuterada deleted the update-contributing branch March 20, 2018 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update contributing #121

Update contributing #121

naokazuterada commented Mar 11, 2018

codecov bot commented Mar 11, 2018 •

edited

Loading

coveralls commented Mar 11, 2018 •

edited

Loading

jonasbn commented Mar 11, 2018

jonasbn left a comment

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018 •

edited

Loading

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

jonasbn Mar 19, 2018

naokazuterada Mar 20, 2018

naokazuterada commented Mar 20, 2018 •

edited

Loading


		### Way of operation

		1. The contributors will `Close` these Issues or PR

		# What actually occurred

		# What version of the involved component

		You should label `feature-request`.


		If your purpose is different, please visit following links.


		Template: FEATURE REQUEST

		This is an issue for a feature request.

		You should label `question`.


		If your purpose is different, please visit following links.

Update contributing #121

Update contributing #121

Conversation

naokazuterada commented Mar 11, 2018

codecov bot commented Mar 11, 2018 • edited Loading

Codecov Report

coveralls commented Mar 11, 2018 • edited Loading

jonasbn commented Mar 11, 2018

jonasbn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naokazuterada Mar 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naokazuterada commented Mar 20, 2018 • edited Loading

codecov bot commented Mar 11, 2018 •

edited

Loading

coveralls commented Mar 11, 2018 •

edited

Loading

naokazuterada Mar 20, 2018 •

edited

Loading

naokazuterada commented Mar 20, 2018 •

edited

Loading