Support markdownpreview #99
Conversation
* master: Bump version to 2.3.1 Allow blockquotes with indentation #32
* master: Unification of notation Make the tile plural Fix typo Add 'MD_numbered_headers' link to README #91
* master: (27 commits) Fix typo Add badges Apply to codecov Bump version to 2.3.2 Add 'install_package_control' Add 'install_package_control' step into install section Remove bs4 dir and use dependencies.json Add 'sudo' Remove InsecurePlatformWarning fixings Use apt-get Fix: InsecurePlatformWarning Remove coverage Add coveralls.yml Add coveralls configs Revert to 9117e7c Unify pip install once Fix error on travis Bumpe version to 2.3.2 Use dependencies.json instead of local bs4 Add badge to README ...
…o use with 'delegate_to_markdown_preview=github'
* master: Fix table Add label for badges
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 89.23% 91.33% +2.09%
==========================================
Files 1 1
Lines 223 277 +54
==========================================
+ Hits 199 253 +54
Misses 24 24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @naokazuterada
I have made some comments on the README. Minor rephrasing, this looks really good 👍
README.md
Outdated
| @@ -401,6 +402,45 @@ As mentioned you can disable this by setting the `uri_encoding` attribute to `fa | |||
| # 中国的例子 | |||
| ``` | |||
|
|
|||
| #### Markdown Preview compatible | |||
|
|
|||
| If you want to use this plugin with [Markdown Preview][MarkdownPreview], you should use `markdown_preview` attribute. | |||
There was a problem hiding this comment.
I would change "this plugin" to "MarkdownTOC"
README.md
Outdated
| #### Markdown Preview compatible | ||
|
|
||
| If you want to use this plugin with [Markdown Preview][MarkdownPreview], you should use `markdown_preview` attribute. | ||
| You should set this attribute to `markdown` or `github`. |
There was a problem hiding this comment.
I would rephrase this to: "You can set this attribute to either ..."
README.md
Outdated
| # ПРИМЕР RUSSIAN | ||
| ``` | ||
|
|
||
| It doesn't support any other parsers. |
There was a problem hiding this comment.
I would rephrase this to: "Currently no other parsers are supported."
1 similar comment
|
@jonasbn Thank you for reviewing! I've modified in accordance with your comments. |
|
Just let me know if there is anything else, my vacation last until the end of the week, then it is back to work :-) jonasbn |
|
Hi @jonasbn , sorry, I just want you to change your review status if all changes are OK and there are nothing else to change. |
Hello @jonasbn
This PR is associated with Issue #94.
Please check especially texts on README.