This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
support open web page from mobile safari #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoya
added a commit
that referenced
this pull request
Sep 21, 2013
support open web page from mobile safari
|
Good Job! |
|
👍 |
|
これだと Pocket が Safari での oAuth だった場合が NG、なのをいま発見しました。別 issue にします |
|
@naoya なるほど、その遷移の場合通過するんですね。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mobile safariからのブックマークレットを使った「webページを開く」を実装してみました。
PocketAPI との処理の分岐は sourceApplication を参照して分岐するようにしています。
課題としては、sourceApplication で判断しているため、ブラウザ毎に対応する必要があるので、もう少しベストプラクティスな方法がないか検討してみたいところですね。
動作確認の方法
javascript:window.location='hbfav2:'+window.location4 のブックマークレットの貼り付けがうまくいかない場合は、一度アドレスバーのURLを削除した状態でペーストすると良いと思います。