-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#62 の受け入れテスト #94
Merged
#62 の受け入れテスト #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
超ありがとうございます! 箇条書きは、元のテストのままのほうが助かるのですが、難しそうでしょうか?
引用は、明朝体なこともゴシック体なこともあるので、 |
了解です。 b17dfe7 で対応しました。 ちなみに引用部分のフォントをどちらにすべきかはどういう条件で決まるんでしょう? |
あ、コラム本文も |
@inao ping! |
なるほどー。じゃあひとまずこのP-Rはマージしても大丈夫でしょうか? |
はい、マージします! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gfx
#62 の受け入れテストを書きました。
テストにミスがあるかもしれません。
ご確認願います。