Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

EOSDriver.get_users() returns empty string for sshkeys #168

Closed
bewing opened this issue Jun 22, 2017 · 0 comments
Closed

EOSDriver.get_users() returns empty string for sshkeys #168

bewing opened this issue Jun 22, 2017 · 0 comments

Comments

@bewing
Copy link
Member

bewing commented Jun 22, 2017

Setup

napalm-eos version

(Paste verbatim output from pip freeze | grep napalm-eos between quotes below)

napalm-eos==0.5.6

eOS version

(Paste verbatim output from show version | json between quotes below)

{u'architecture': u'i386',
 u'bootupTimestamp': 1496206084.68,
 u'hardwareRevision': u'02.02',
 u'internalBuildId': u'13357416-6616-4a73-b088-cfbfcedd7078',
 u'internalVersion': u'4.18.2F-2GB-4930939.4182F',
 u'isIntlVersion': False,
 u'memFree': 2299720,
 u'memTotal': 3963676,
 u'modelName': u'DCS-7150S-52-CL-R',
 u'serialNumber': u'JPE15083350',
 u'systemMacAddress': u'00:1c:73:b4:d1:bf',
 u'version': u'4.18.2F-2GB'}

What I would expect

In [11]: d.get_users()['admin']
Out[11]: {u'level': 15, u'password': u'', u'role': u'network-admin', u'sshkeys': []}

What I get

In [11]: d.get_users()['admin']
Out[11]: {u'level': 15, u'password': u'', u'role': u'network-admin', u'sshkeys': [u'']}

Will submit PR in napalm_eos to fix, and update unit test in napalm_base to enumerate sshkeys and confirm the strings are valid keys.

bewing added a commit to bewing/napalm-eos that referenced this issue Jun 22, 2017
@bewing bewing mentioned this issue Jun 22, 2017
dbarrosop pushed a commit that referenced this issue Jun 26, 2017
* Fixes #168

* Add unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant