OSPF parser for Junos #146
Conversation
|
@dbarrosop do not merge! despite passing the tests, I made a mistake and lost the data in the tests... I need to review it. Sorry for that |
|
ok ,ping me when this is ready for review :) |
|
now I understand... I only implemented the parser. However for the tests the translator is needed as well 😅 I'll try but it may take a while... |
|
@dbarrosop Please have a look... Note I had to remove from the tests the |
| post: "simple-password" | ||
| - path: authentication | ||
| present: false | ||
| post: "none" |
There was a problem hiding this comment.
should this be null instead? I'd expect this leaf to be empty if there is no authentication. The model is unclear though here, it just says "string".
There was a problem hiding this comment.
@dbarrosop The translation from Junos -> OC with OSPF authentication is working with the current code, so I would not remove anything 😃
What I meant is I did not include any OSPF authentication in the tests because they were failing due to the OC not supporting the key. Let me know if not clear. Thanks!
|
Awesome work, just had a tiny comment :) |
@dbarrosop reopening as requested. Thanks