-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change type for variables to bool #132
Conversation
Hi! Thanks! |
Just updated doctoring. |
Thanks! Will do some tests soon and approve the PR if I don't see anything wrong (I a sure I wont but better safe than sorry). I am still enjoying some days off so I guess I will take a look early next week : ) |
Hi! As you probably read here: https://groups.google.com/forum/#!topic/napalm-automation/DI2w4s1vk9I We have changed the organization and moved the ansible plugins to a dedicated repo. Would you mind closing this PR and sending a new one to the new repo? The reason why I prefer to do this is so your contribution is not lost during the movement. |
New pull request in separate repository |
Detect the format of the config and try loading it
This commit will change variables commit_changes and replace_config to bool.
Also according to the doc string replace_config variable is not required but has default set to false.
After this change module will accept following values for mentioned variables:
yes,on,1,true,1,no,off,0,false,0
After this change module will not be backward compatible if someone used values "True" or "False" as in following example
msg: value of replace_config must be one of: yes,on,1,true,1,no,off,0,false,0, got: False