Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent speed/uptime between model and documentation #1650

Closed
M0NsTeRRR opened this issue May 25, 2022 · 3 comments · Fixed by #1651
Closed

Inconsistent speed/uptime between model and documentation #1650

M0NsTeRRR opened this issue May 25, 2022 · 3 comments · Fixed by #1651

Comments

@M0NsTeRRR
Copy link
Contributor

Hello,

I'm currently implementing a napalm driver.
On NetworkDriver documentation it says get_interfaces() has an attribute speed that must be an int in Mbit.
https://napalm.readthedocs.io/en/latest/base.html#napalm.base.base.NetworkDriver.get_interfaces
But in testing framework the model says it must be a float

"speed": float,

Best regards,

@M0NsTeRRR
Copy link
Contributor Author

Also for get_facts() has an attribute uptime that must be a float in seconds (in the example).
https://napalm.readthedocs.io/en/latest/base.html#napalm.base.base.NetworkDriver.get_facts
But in testing framework the model says it must be an int

"uptime": int,

@M0NsTeRRR M0NsTeRRR changed the title Inconsistent speed between model and documentation Inconsistent speed/uptime between model and documentation May 25, 2022
@network-shark
Copy link
Contributor

network-shark commented May 30, 2022

@M0NsTeRRR Speed changed to float in one of the last releases. It seems that I forgot to change the documentation.

@M0NsTeRRR
Copy link
Contributor Author

I've reverted code change & updated the doc @network-shark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants