Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXOS add mtu get interfaces #539

Merged
merged 2 commits into from
Nov 19, 2017
Merged

NXOS add mtu get interfaces #539

merged 2 commits into from
Nov 19, 2017

Conversation

afourmy
Copy link
Contributor

@afourmy afourmy commented Nov 18, 2017

Add MTU to get_interface for the NXOS-SSH driver.

@afourmy
Copy link
Contributor Author

afourmy commented Nov 18, 2017

test/nxos_ssh/test_getters.py::TestGetter::test_get_interfaces[5548_7_0_8_N1_1] PASSED
test/nxos_ssh/test_getters.py::TestGetter::test_get_interfaces[alternate1] PASSED
test/nxos_ssh/test_getters.py::TestGetter::test_get_interfaces[normal] PASSED

=> Tests are OK

The overall build fails because I updated the data model in the IOS PR.
However, I saw that for junos, it fails because of the type

test/junos/test_getters.py::TestGetter::test_get_interfaces[normal] <- napalm/base/test/getters.py key: mtu
model_class: <class 'int'>
data_class: <class 'str'>
FAILED

I think the MTU type should be updated to int in the junos PR

@ktbyers ktbyers merged commit 78fdf6d into napalm-automation:get_interfaces_mtu3 Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants