Update version switcher json #109
Conversation
github-actions
bot
added
the
documentation
|
it looks working because of andy PR napari/napari.github.io#375 |
|
Yes - in fact I think this json here should be removed, as the json being used is the one on the napari.github.io repo. I think this was an oversight when we made the final decision on how to deploy the website. |
|
I've thought about this a bit longer, and I would like us to half-reverse this decision: I think we should use the json from the website, but I think the json from the website should be deployed from this repo. The website itself should be a repository of derived products, not the source of anything — it becomes confusing when it is source for some things mixed in with derived products for other things. What do you think @melissawm @Czaki? |
|
... Looking at it more closely, this would simply mean we start using the version switcher url at |
|
Yes - the only requirement is that this needs to be a live link for the json to work (meaning: you can't build with a local json file). Other than that, as long as we use a permalink this should work just fine 👍 |
|
Good-oh. Should we merge this PR then? 😅 Then we can update the one on the website. |
This is a follow-up on naparigh-109.
# Description Update URL of version switcher to use https://napari.org/dev/_static/version_switcher.json This brings us closer to the goal of napari.github.io containing only built artifacts, not source materials. ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Fixes or improves existing content - [ ] Adds new content page(s) - [x] Fixes or improves workflow, documentation build or deployment # References This is a follow-up on #109. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added [alt text](https://webaim.org/techniques/alttext/) to new images included in this PR
I have to say I don't understand why anything in the site version switcher is working currently given the status of the version switcher json... @melissawm Any thoughts? Is this version not uploaded to the deployed repo? At any rate, this makes it correct. (I added the version number to the "stable" name as I think it's handy.)