Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signpost to make_napari_viewer code #151

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix signpost to make_napari_viewer code #151

merged 1 commit into from
May 18, 2023

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 10, 2023 •
edited
Loading

Description

The path in this signpost is out of date, so I've fixed it.

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 10, 2023
@dstansby dstansby removed their assignment May 10, 2023
@Czaki
Copy link
Contributor

Czaki commented May 10, 2023

I think that you should update path to the current one (napari/utils/_testsupport.py)

@dstansby
Copy link
Contributor Author

👍 done

@Czaki
Copy link
Contributor

Czaki commented May 11, 2023

Could you update the title and description to reflect current changes?

@dstansby dstansby changed the title Remove signpost to make_napari_viewer code Fix signpost to make_napari_viewer code May 11, 2023
@dstansby
Copy link
Contributor Author

Woops, thanks for noticing, should be better now 😄

@psobolewskiPhD psobolewskiPhD merged commit 9060b24 into napari:main May 18, 2023
@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.4.18
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @Czaki @psobolewskiPhD