Add some more docs about packaging details and conda-forge releases #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Czaki
approved these changes
Nov 13, 2022
|
Anything else needed here so this gets merged? 🙏 |
psobolewskiPhD
approved these changes
Jan 9, 2023
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
|
Thank you @psobolewskiPhD! |
melissawm
reviewed
Jan 27, 2023
Czaki
requested changes
Jan 27, 2023
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
psobolewskiPhD
requested changes
Feb 2, 2023
psobolewskiPhD
approved these changes
Feb 2, 2023
|
As far as I'm concerned this is good to go now, @Czaki any last comments? |
Czaki
reviewed
Feb 2, 2023
|
Anything else needed, team? |
Czaki
reviewed
Mar 27, 2023
docs/developers/packaging.md
Outdated
| @@ -113,10 +118,10 @@ specs: # specs for the 'base' environment | |||
| - mamba # we add these to manage different napari versions | |||
| - pip # we add these to manage different napari versions | |||
| extra_envs: | |||
| napari-0.4.16: # this is the environment that will actually contain the napari packages | |||
| napari-0.4.17: # this is the environment that will actually contain the napari packages | |||
There was a problem hiding this comment.
could we generate this yaml file using template tags to ensure that it will be kept up to date without manual interventions?
There was a problem hiding this comment.
Unfortunately this is not supported in MyST. See warnings.
There was a problem hiding this comment.
Instead I added the term "hypothetical" to make clear we are only providing an example that is not meant to be up to date with the current version. Let me know what you think @Czaki
Czaki
approved these changes
May 10, 2023
|
Is this good to go? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The packaging docs needed some subtle changes in wording and content.
Type of change
References
Closes napari/packaging#2
How has this been tested?
Final checklist:
trans.to make them localizable.For more information see our translations guide.
Side question: is the issue template accurate for this repository? It feels we could have a more relatable one :D