Labels layer: add keybinding to set the label to 0 #5666
Comments
psobolewskiPhD
added
task
6 tasks
|
Well one question is why is it "m" — oh right for max. Anyway, I think n could be confusing because |
12 tasks
brisvag
pushed a commit
that referenced
this issue
Apr 5, 2023
…ng) (#5672) # Description This adds an action analogous to the current `new_label` action (current keybind `M`) to set the current label to background (0). The default keybind has been set to `B` because it's close to space and close M, plus B for `background`. Open to other suggestions. This is sort of similar to `activate_labels_erase_mode` but in a lot of ways more powerful, because you can use the `fill` tool to erase contiguous areas. ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug-fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5666 First came up in a docs PR: napari/docs#125 (comment) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] example: I added a test - [x] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation: will update napari/docs#125 once the default keybind is settled. - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
kcpevey
pushed a commit
to kcpevey/napari
that referenced
this issue
Apr 6, 2023
…ng) (napari#5672) # Description This adds an action analogous to the current `new_label` action (current keybind `M`) to set the current label to background (0). The default keybind has been set to `B` because it's close to space and close M, plus B for `background`. Open to other suggestions. This is sort of similar to `activate_labels_erase_mode` but in a lot of ways more powerful, because you can use the `fill` tool to erase contiguous areas. ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug-fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes napari#5666 First came up in a docs PR: napari/docs#125 (comment) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] example: I added a test - [x] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation: will update napari/docs#125 once the default keybind is settled. - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🧰 Task
There is the ability to set a new label, bound by default to
m, but there isn't an easy way to set the label to0such that the fill tool can use used to erase in bulk, so to speak.There should be an easy keybind for this that should be editable by the user. Perhaps
nbecause it's close tomand the spacebar?The text was updated successfully, but these errors were encountered: