-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out builtins into another top-level module #4706
Conversation
for more information, see https://pre-commit.ci
…into split-builtins
when we move part of code to new top level package, then maybe new entry should be added to |
Codecov Report
@@ Coverage Diff @@
## main #4706 +/- ##
==========================================
- Coverage 87.68% 87.59% -0.09%
==========================================
Files 589 580 -9
Lines 50631 49715 -916
==========================================
- Hits 44394 43549 -845
+ Misses 6237 6166 -71
Continue to review full report at Codecov.
|
Seems like a real fail... are the readers actually being installed? |
Yeah agreed, will look. They certainly make it into the local sdist/wheel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this so much! @tlambert03 if you can chase down that test fail then I think this can merge!! 🚀
that seems to have fixed it, just split up the --pyargs tests into two steps |
Nice - all tests now passing. Let's see if @jni has any comments on this - otherwise i think it's good to merge! |
This has been approved for a week now - unless hearing anything else by tomorrow I will merge, thanks all!!! |
Description
This PR would split our "builtins" plugins into a new top-level module
napari_builtins
. In this PR, it remains distributed withnapari
package on PyPI. If we want to go in this direction (as has been discussed) i think it would be good to have at least a little period of co-existence of the two packages in the same repo, since I think there will likely be some follow-ups. Particularly with regards to testing: we currently do a lot of sorta-kinda indirect integration testing and it would be a good opportunity to clean up our tests to clarify whether we're testing how napari calls plugins, vs how our builtin plugin works.i think most tests are passing currently, but still in draft cause I want to go back and clean up the tests even more
Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.