New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show_debug notification #5101
Conversation
Click here to download the docs artifacts |
Codecov Report
@@ Coverage Diff @@
## main #5101 +/- ##
=======================================
Coverage 89.35% 89.36%
=======================================
Files 601 601
Lines 51153 51158 +5
=======================================
+ Hits 45707 45716 +9
+ Misses 5446 5442 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks @seankmartin for this PR! I'm adding @brisvag or @Czaki as reviewers since it seems this went overlooked. If there is someone else who would be better to review, feel free to swap! |
Good, seems pretty straightforward to me. I'm not sure I understand how to enable/disable this when actually using napari. Is the default loglevel |
As I understand it (please correct me if wrong!) There are two default log levels set here napari/napari/settings/_application.py Lines 104 to 115 in ee94c35
By default To change the level in napari and see the
Or if using the GUI, you can set it in Preferences -> Application -> GUI notification level / Console notification level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the rundown! Seems useful to me :)
* main: (38 commits) Fix `test_worker_with_progress` by wait on worker end (napari#5548) Un-set unified title and tool bar on mac (Qt property) (napari#5533) Set PYTHONEXECUTABLE as part of macos fixes on (re)startup (napari#5531) Fix key error issue of action manager (napari#5539) Clean dangling widget in test (napari#5544) Use pytest-pretty for better log readability (napari#5525) Update vendoring tool to check on matplotlib colormap (napari#5181) MAINT: add time limit for CI. (napari#5495) Add show_debug notification (napari#5101) Overlays 2.0 (napari#4894) Clarify layer's editable property and separate interaction with visible property (napari#5413) ci(dependabot): bump docker/build-push-action from 3 to 4 (napari#5523) Fix opening file dialogs in PySide (napari#5492) [pre-commit.ci] pre-commit autoupdate (napari#5518) Replace flake8, isort and pyupgrade by ruff, enable additional usefull rules (napari#5513) MAINT: Don't format logs in log call (napari#5504) Fix conda avaliability check (napari#5496) Handle case when QtDims play thread is partially deleted (napari#5499) Bugfix: Add missing Enums and Flags required by PySide6 > 6.4 (napari#5480) Refactor Main Window status bar to improve information presentation (napari#5451) ...
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com> Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Description
This PR is to add a
show_debug
notification function, to round out the existing functionality to show info, warning, and error.I've been looking into plugin debugging in relation to #2948. I noticed that there was no
show_debug
function, which I thought might be a nice way to help debugging as the console log level preferences in napari can be set toinfo
level to hide these.Open to thoughts though if there is a reason it would be preferred not to have this function! I could use an alternative if so, outside of core, something like:
Type of change
References
Related to #2948 as I noticed it during writing this guide.
How has this been tested?
show_x
notification functionalityFinal checklist:
trans.
to make them localizable.For more information see our translations guide.