Un-set unified title and tool bar on mac (Qt property)

[aganders3]

Description

This one is a bit weird, but here goes. This fixes the background "behind" the QtViewerDockWidgets being the wrong color (something from the system theme). I think this was actually the root cause of the issues seen in #5529 and addressed separately in #5526. I could go either way then on whether to include the changes in #5526 as well.

Anyway this removes a property that was set to fix an intermittent problem quite a while ago. It seems the behavior of this property actually changed in Qt5, and it is supposedly not compatible with windows that contain Open GL content.

Before this change

After this change

Type of change

• Bug-fix (non-breaking change which fixes an issue)

References

#245
#239
#5529
#5526

How has this been tested?

• I checked my changes work with both PySide and PyQt backends on Qt6, and PyQt on Qt5

Final checklist:

• My PR is the minimum possible work for the desired functionality

[codecov]

Codecov Report

Merging #5533 (b30dd7a) into main (ef76a46) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5533   +/-   ##
=======================================
  Coverage   89.36%   89.37%           
=======================================
  Files         608      608           
  Lines       51097    51096    -1     
=======================================
+ Hits        45664    45667    +3     
+ Misses       5433     5429    -4     

Impacted Files	Coverage Δ
napari/_qt/qt_main_window.py	74.34% <ø> (-0.22%)	⬇️
napari/_qt/dialogs/qt_package_installer.py	81.81% <0.00%> (+0.39%)	⬆️
napari/utils/theme.py	94.04% <0.00%> (+0.59%)	⬆️
napari/utils/info.py	85.10% <0.00%> (+1.06%)	⬆️
napari/_qt/__init__.py	56.66% <0.00%> (+6.66%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[psobolewskiPhD]

For me this works perfectly and it's quite simple.
I wonder if this will mess something up on some sort of minimum requirements install?
But from reading the old threads, it's clear that the original issue wasn't easy to trigger, because none of the other mac users at the time had the issue.

One thing that makes this better is that the background when undocking is set by the napari theme and not OS theme. Now, I prefer to have napari and OS synced, but if you don't and you try to undock a widget it will look horrible. The other PR does not fix that on my end with pyside6.

Maybe @dalthviz has some insight, as original qss 🧙‍♂️ ?

[aganders3]

One thing that makes this better is that the background when undocking is set by the napari theme and not OS theme.

Yeah this is what I set out to fix with this one.

I can go either way about including the changes from the other PR in addition. They still make sense to me, but I think with this change they're not strictly necessary. I'll happily defer to the resident Qt experts!

[brisvag]

I wonder if this will mess something up on some sort of minimum requirements install?

We do have minreq in our tox matrix, so we should be good on that front :)

[dalthviz]

Maybe for an older Qt5 version like 5.6 or 5.9 or older MacOS versions was necessary to set that property for some reason? I think this solution makes sense 👍 (it's always nice to find a one liner solution for multiple problems and even better if it is done by removing code :) )

[psobolewskiPhD]

Man these tests failing pyqt5/python 3.8 are a bummer :(
At least the dims ones would pass if rerun!
When do we drop python 3.8? 👀

[Czaki]

Man these tests failing pyqt5/python 3.8 are a bummer :(

this is not a problem with python 3.8 I observed it also on other python version.

[psobolewskiPhD]

Based on the above approvals and the comment from @dalthviz I think this is ready to merge.
Starting the clock—I use pyside6 in my dev env, so this is a QoL issue for me!