Fix opening file dialogs in PySide

[Czaki]

Description

Even if official documentation of qt says that the argument of getOpenFileNames is named dir, the dir is a builtin function in python, so PySide2, PyQt5, and PyQt6 use directory as the argument name. But PySide6 breaks this.

The PyQt6 does not support QFileDialog.Options()

Type of change

• Bug-fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

References

How has this been tested?

• example: the test suite for my feature covers cases x, y, and z
• example: all tests pass with my change
• example: I check if my changes works with both PySide and PyQt backends
  as there are small differences between the two Qt bindings.

Final checklist:

• My PR is the minimum possible work for the desired functionality
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• If I included new strings, I have used trans. to make them localizable.
  For more information see our translations guide.

[codecov]

Codecov Report

Merging #5492 (95ce540) into main (180992f) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #5492   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files         600      600           
  Lines       51060    51066    +6     
=======================================
+ Hits        45605    45614    +9     
+ Misses       5455     5452    -3     

Impacted Files	Coverage Δ
napari/_qt/qt_viewer.py	78.78% <83.33%> (-0.15%)	⬇️
napari/_qt/dialogs/qt_package_installer.py	81.67% <0.00%> (+0.39%)	⬆️
napari/utils/theme.py	92.89% <0.00%> (+0.59%)	⬆️
napari/utils/info.py	81.44% <0.00%> (+1.03%)	⬆️
napari/_qt/__init__.py	56.66% <0.00%> (+6.66%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[psobolewskiPhD]

I merged this with the other pyside6 PR and it works nice.
Makes sense to me.

Out of curiosity, it's >10 lines duplicated—does it make sense from a maintenance PoV to make this a function?

[Czaki]

Out of curiosity, it's >10 lines duplicated—does it make sense from a maintenance PoV to make this a function?

done

[psobolewskiPhD]

Out of curiosity, it's >10 lines duplicated—does it make sense from a maintenance PoV to make this a function?

done

Bah, you didn't have to! I was just asking! 😬

BTW I get this message in console:

2023-01-19 21:08:39.248 napari[35804:10079388] +[CATransaction synchronize] called within transaction

Seems like it may be macOS 13 specific:
https://forum.qt.io/topic/141868/macos-catransaction-synchronize-called-within-transaction/7
Just putting this somewhere for future reference.

[Czaki]

Bah, you didn't have to! I was just asking! grimacing

but it is improvement

[psobolewskiPhD]

Kinda amazing this was missed this long, but I have to admit when I was new I used File > Sample and drag-n-drop and now I largely use those two plus programatic methods. So I'm never doing File > Open.

[Czaki]

An badly it is not possible to test this in normal way.

Maybe I should bring issue to provide both PySide and PyQt bundles?