Fix key error issue of action manager #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors fail due to known memory leak issue not caused by these code changes. |
Codecov Report
@@ Coverage Diff @@
## main #5539 +/- ##
=======================================
Coverage 89.36% 89.37%
=======================================
Files 608 608
Lines 51097 51097
=======================================
+ Hits 45664 45669 +5
+ Misses 5433 5428 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Czaki
approved these changes
Feb 7, 2023
psobolewskiPhD
approved these changes
Feb 7, 2023
|
starting 24h clock |
|
As I understand, we plan to move out of action manager to app_model. And as I understand the app model approach allows to validation action existence on binding. |
kne42
added a commit
to kne42/napari
that referenced
this pull request
Feb 28, 2023
* main: (38 commits) Fix `test_worker_with_progress` by wait on worker end (napari#5548) Un-set unified title and tool bar on mac (Qt property) (napari#5533) Set PYTHONEXECUTABLE as part of macos fixes on (re)startup (napari#5531) Fix key error issue of action manager (napari#5539) Clean dangling widget in test (napari#5544) Use pytest-pretty for better log readability (napari#5525) Update vendoring tool to check on matplotlib colormap (napari#5181) MAINT: add time limit for CI. (napari#5495) Add show_debug notification (napari#5101) Overlays 2.0 (napari#4894) Clarify layer's editable property and separate interaction with visible property (napari#5413) ci(dependabot): bump docker/build-push-action from 3 to 4 (napari#5523) Fix opening file dialogs in PySide (napari#5492) [pre-commit.ci] pre-commit autoupdate (napari#5518) Replace flake8, isort and pyupgrade by ruff, enable additional usefull rules (napari#5513) MAINT: Don't format logs in log call (napari#5504) Fix conda avaliability check (napari#5496) Handle case when QtDims play thread is partially deleted (napari#5499) Bugfix: Add missing Enums and Flags required by PySide6 > 6.4 (napari#5480) Refactor Main Window status bar to improve information presentation (napari#5451) ...
Czaki
added
the
triaged-0.4.18
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue described in #5535. Due to the action manager bindings being incorrect, key errors were thrown when using the functionality of the labels layer.
Type of change
References
#5535
How has this been tested?
Passed the tests in napari.layers and manually tested
Final checklist:
trans.to make them localizable.For more information see our translations guide.