Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic] Update albertosottile/darkdetect vendored module #5394

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2022

This PR is automatically created and updated by napari GitHub
action cron to keep vendored modules up to date.

It look like albertosottile/darkdetect has a new version.

@Czaki
Copy link
Collaborator

Czaki commented Dec 7, 2022

The test is not starting as github action created PR does not trigger action run.
Currently, we need to manually trigger it by merging changes from the main.

peter-evans/create-pull-request#48

We could change this by use personal access token as GitHub secret for opening PR.

@brisvag
Copy link
Contributor

brisvag commented Dec 8, 2022

I'm not following; I thought this kinf of PR always worked? And can't we trigger manually somehow?

@Czaki
Copy link
Collaborator

Czaki commented Dec 8, 2022

I'm not following; I thought this kinf of PR always worked? And can't we trigger manually somehow?

I do not know how it is in the past. I know that currently this type of PR will not start other workflows.

@brisvag
Copy link
Contributor

brisvag commented Dec 8, 2022

Ok, took a look at the PR, makes sense. We need someone with secret access to take care of this; @jni @sofroniewn ?

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #5394 (0bcc874) into main (9eeab55) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0bcc874 differs from pull request most recent head 49a7159. Consider uploading reports for the commit 49a7159 to get more accurate results

@@            Coverage Diff             @@
##             main    #5394      +/-   ##
==========================================
- Coverage   89.01%   89.01%   -0.01%     
==========================================
  Files         594      594              
  Lines       50237    50237              
==========================================
- Hits        44720    44718       -2     
- Misses       5517     5519       +2     
Impacted Files Coverage Δ
...layers/image/experimental/_chunked_image_loader.py 88.00% <0.00%> (-8.00%) ⬇️
napari/layers/tracks/_track_utils.py 88.06% <0.00%> (-3.41%) ⬇️
napari/layers/image/_image_slice.py 97.61% <0.00%> (-2.39%) ⬇️
napari/layers/tracks/tracks.py 94.29% <0.00%> (-0.39%) ⬇️
napari/layers/image/image.py 95.48% <0.00%> (-0.26%) ⬇️
napari/utils/theme.py 89.79% <0.00%> (+0.68%) ⬆️
napari/utils/info.py 81.44% <0.00%> (+1.03%) ⬆️
napari/_qt/__init__.py 56.66% <0.00%> (+6.66%) ⬆️
napari/components/experimental/chunk/_pool.py 93.65% <0.00%> (+7.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brisvag brisvag merged commit 58c0ca8 into main Dec 12, 2022
@brisvag brisvag deleted the update-vendored-examples branch December 12, 2022 09:20
aganders3 pushed a commit to aganders3/napari that referenced this pull request Dec 20, 2022
…5394)

Co-authored-by: Carreau <Carreau@users.noreply.github.com>
melissawm pushed a commit to melissawm/napari that referenced this pull request Jan 11, 2023
…5394)

Co-authored-by: Carreau <Carreau@users.noreply.github.com>
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 13, 2023
@Czaki Czaki added maintenance PR with maintance changes, triaged-0.4.18 labels Jun 13, 2023
Czaki pushed a commit that referenced this pull request Jun 16, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 17, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 18, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 19, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Carreau <Carreau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants