Move layer editable change from slicing to controls #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-sweet
changed the title
andy-sweet
commented
Feb 9, 2023
| @@ -148,7 +148,7 @@ def _add(self, event): | |||
| """ | |||
| layer = event.value | |||
| controls = create_qt_layer_controls(layer) | |||
| controls.ndisplay = 3 | |||
There was a problem hiding this comment.
I have no idea why I set this to 3 specifically in #5491...
|
@jni : we discussed this in the recent architecture working group meeting, so I assigned you to review. Let me know if you want someone else to take a look instead or in addition. |
Codecov Report
@@ Coverage Diff @@
## main #5546 +/- ##
==========================================
+ Coverage 89.36% 89.37% +0.01%
==========================================
Files 608 608
Lines 51098 51109 +11
==========================================
+ Hits 45663 45679 +16
+ Misses 5435 5430 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andy-sweet
changed the title
jni
approved these changes
Feb 17, 2023
|
Thanks for the quick review! I'll merge this shortly after the weekend unless there are any objections. |
Czaki
approved these changes
Feb 17, 2023
brisvag
removed
the
ready to merge
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves some side-effects of changing the display dimensionality from
Layer._slice_dimsto the layer controls. This means the side-effects typically only occur in the full viewer.Alternatively, we could consider connecting
Dims.ndisplayto this side-effect inViewerModel, so that a more standard headless napari would see the same behavior.A further alternative is to not have the side-effect on
Layer.editableand instead just update the layer control editable buttons' enabled state directly.Motivation
This is partially motivated by the async slicing/loading work (#4795) because it makes
Layer._slice_dimsalmost identical toLayer.refresh, except that_slice_dimsmay still sometimes return early. More specifically, it would allow us to simplify the sync default/fallback option when integrating async slicing.One upside is that the tests exercise some public API (even if it's part of napari's Qt/GUI code), rather than calling a private method as their main action.