Simplify unused parameters of Quaternion functions. #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
added
breaking change
|
This is technically a breaking change, but in a private module. This should have been already agreed in #6241 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
==========================================
- Coverage 92.23% 92.16% -0.07%
==========================================
Files 601 601
Lines 53175 53173 -2
==========================================
- Hits 49046 49008 -38
- Misses 4129 4165 +36 ☔ View full report in Codecov by Sentry. |
brisvag
approved these changes
Nov 9, 2023
Carreau
removed
the
breaking change
This is a partial reapply of napari#6241, that was reverted, but reapply only the part where we simplify the API that has an unsed argument and rename the function. This is thus a partial revert of napari#6299 which itself is a revert of napari#6241
andy-sweet
added
the
ready to merge
|
thanks, much appreciated and happy new year!
…On Tue, Jan 9, 2024 at 00:24 Juan Nunez-Iglesias ***@***.***> wrote:
Merged #6424 <#6424> into main.
—
Reply to this email directly, view it on GitHub
<#6424 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR5T52IEPG7ARC6Z7S7IDYNR54FAVCNFSM6AAAAAA7DBCMI2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQZDGNJVGU2TMNA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kne42
added a commit
to kne42/napari
that referenced
this pull request
Jan 11, 2024
* main: Fix labels mapping cache by filling it with background, not 0 (napari#6580) Simplify unused parameters of Quaternion functions. (napari#6424) Add size and ndim to LayerDataProtocol (napari#6494) Fix label direct mode for installation without numba (napari#6571) Fix test in napari_builtins to remove import from conftest (napari#6568) Remove `app-model!=0.2.4` from test constraints (napari#6577) Bump mypy version and fix errors (napari#6557) Update test to work with `app-model==0.2.4` (napari#6573) Added support for features in surface layers (napari#6515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial reapply of #6241, that was reverted, but reapply only the part where we simplify the API that has an unsed argument and rename the function.
This is thus a partial revert of #6299 which itself is a revert of #6241