Add size and ndim to LayerDataProtocol #6494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Nov 23, 2023
|
add the corresponding ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6494 +/- ##
==========================================
- Coverage 92.24% 92.19% -0.05%
==========================================
Files 601 601
Lines 53210 53236 +26
==========================================
- Hits 49081 49079 -2
- Misses 4129 4157 +28 ☔ View full report in Codecov by Sentry. |
Czaki
reviewed
Nov 24, 2023
in `napari/layers/image/image.py`, `_calc_data_range(self...)` calls `calc_data_range(input_data,...)` where `input_data` is a `LayerDataProtocol` `calc_data_range(...)` needs it to have a size, and ndim. So my guess is we need to make sure that LayerDataProtocol has size and ndim, is that correct ?
Czaki
added
maintenance
kne42
added a commit
to kne42/napari
that referenced
this pull request
Jan 11, 2024
* main: Fix labels mapping cache by filling it with background, not 0 (napari#6580) Simplify unused parameters of Quaternion functions. (napari#6424) Add size and ndim to LayerDataProtocol (napari#6494) Fix label direct mode for installation without numba (napari#6571) Fix test in napari_builtins to remove import from conftest (napari#6568) Remove `app-model!=0.2.4` from test constraints (napari#6577) Bump mypy version and fix errors (napari#6557) Update test to work with `app-model==0.2.4` (napari#6573) Added support for features in surface layers (napari#6515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
napari/layers/image/image.py,_calc_data_range(self...)callscalc_data_range(input_data,...)whereinput_datais aLayerDataProtocolcalc_data_range(...)needs it to have a size, and ndim. So my guess is we need to make sure that LayerDataProtocol has size and ndim, is that correct ?Thoughts ?
Typing all the things that need to be types for this problem to show up is quite long, please see all my other typing PRs to start enabling type checking for these files, mostly opening this separately to know if this is something we wan to add to LayerDataProtocol