Bump mypy version and fix errors #6557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6557 +/- ##
==========================================
- Coverage 92.29% 92.25% -0.05%
==========================================
Files 601 601
Lines 53687 53708 +21
==========================================
- Hits 49553 49548 -5
- Misses 4134 4160 +26 ☔ View full report in Codecov by Sentry. |
brisvag
approved these changes
Jan 3, 2024
kne42
added a commit
to kne42/napari
that referenced
this pull request
Jan 11, 2024
* main: Fix labels mapping cache by filling it with background, not 0 (napari#6580) Simplify unused parameters of Quaternion functions. (napari#6424) Add size and ndim to LayerDataProtocol (napari#6494) Fix label direct mode for installation without numba (napari#6571) Fix test in napari_builtins to remove import from conftest (napari#6568) Remove `app-model!=0.2.4` from test constraints (napari#6577) Bump mypy version and fix errors (napari#6557) Update test to work with `app-model==0.2.4` (napari#6573) Added support for features in surface layers (napari#6515)
Czaki
added a commit
that referenced
this pull request
Apr 13, 2024
) # Description The Scientific python has tool named repo-review with set of rules that they think are good for projects. Not all apply to napari, but some of them looks usefull. To see the check on napari repo one may use this link https://learn.scientific-python.org/development/guides/repo-review/?repo=napari%2Fnapari&branch=main This PR contains non mypy improvements, as mypy ones requires improvements in code. It depends on #6557 This PR also enables automatically dump graph when QtViewer is leaked during tests. Then such graph in pdf is uploaded as job artifact. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Mypy and resolve new issues