Update test to work with app-model==0.2.4
#6573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6573 +/- ##
==========================================
- Coverage 92.25% 92.21% -0.05%
==========================================
Files 603 603
Lines 53814 53820 +6
==========================================
- Hits 49648 49630 -18
- Misses 4166 4190 +24 ☔ View full report in Codecov by Sentry. |
|
fwiw, this was a change made at the request of a napari dev: pyapp-kit/app-model#108 |
brisvag
removed
the
ready to merge
kne42
added a commit
to kne42/napari
that referenced
this pull request
Jan 11, 2024
* main: Fix labels mapping cache by filling it with background, not 0 (napari#6580) Simplify unused parameters of Quaternion functions. (napari#6424) Add size and ndim to LayerDataProtocol (napari#6494) Fix label direct mode for installation without numba (napari#6571) Fix test in napari_builtins to remove import from conftest (napari#6568) Remove `app-model!=0.2.4` from test constraints (napari#6577) Bump mypy version and fix errors (napari#6557) Update test to work with `app-model==0.2.4` (napari#6573) Added support for features in surface layers (napari#6515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes pyapp-kit/app-model/issues/171
Description
The app-model 0.2.4 release broke napari test, but it looks like it does not break napari itself (manual testing).
So this PR fixes tests