Add count of discovered plugins #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2801 2806 +5
=========================================
+ Hits 2801 2806 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nclack
approved these changes
Oct 7, 2022
| @@ -71,6 +71,7 @@ testing = | |||
| numpy | |||
| pytest | |||
| pytest-cov | |||
| jsonschema | |||
There was a problem hiding this comment.
Result of setup a fresh environment.
|
Works well with napari/napari#5190, really important fix, because without the warning to the user it seems like the plugin failed to install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods to better trace changes in plugins to have the possibility to message users.
For example to, inform users that there is a need to restart napari after installing the npe2 plugin.