Fix tests by disble broken one #319
Conversation
| @pytest.mark.skip("package looks deleted from pypi") | ||
| def test_fetch_npe1_manifest_with_writer(): | ||
| mf = fetch_manifest("example-plugin") |
There was a problem hiding this comment.
@tlambert03 You have created these tests. Did you know who is the author of the example-plugin and why it was removed from pypi?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ugh sorry @Czaki! Yeah I removed that plugin because I was playing with other things - sorry, didn't realize tests were using it. I can pop it back up,but if we think this test (and others like it) might be critical, we can think about maintaining a dummy plugin within the napari org.
There was a problem hiding this comment.
This is the package used for the npe1 test. So I do not think that it will require maintenance.
But we could migrate it if you wish. Did you still have content of this project?
There was a problem hiding this comment.
I think we should definitely migrate it to npe2 and keep it up to date in the napari org!
There was a problem hiding this comment.
But of course, we could think about a better name if such a need exists.
There was a problem hiding this comment.
Yeah agreed, I think it should be test-dummy-plugin or something. And we should hide it from hub. Or even not add the framework classifier?
There was a problem hiding this comment.
I think that not adding a classifier could be a good idea.
There was a problem hiding this comment.
I think we have different ideas here; I was imagining an actual example-plugin called such, because I can imagine people looking up "napari example plugin" and it would be an easy way in that's not as "scary" as the cookiecutter.
Maybe this just serves a completely different purpose from the testing, in that case maybe this is not the right conversation :P
There was a problem hiding this comment.
ooops sorry @brisvag I missed this comment. I think maybe these are two separate things? I always viewed the cookiecutter as the default plugin template, but I could imagine maintaining some other example plugin - I'm not sure what you think the benefits of it would be, over the cookiecutter though?
In general, I think that should be separate to a plugin that we use for testing purposes though since they're different targets. But yeah, happy to consider a richer demo-like plugin!
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
===========================================
- Coverage 100.00% 99.75% -0.25%
===========================================
Files 37 37
Lines 2814 2814
===========================================
- Hits 2814 2807 -7
- Misses 0 7 +7 |
There was a problem hiding this comment.
@Czaki I'm happy to approve to get at least some green in CI. Once I've got the dummy plugin up (over the weekend most likely), we can come back and update the skipped test.
|
I do not have permission to merge it. Should I change codecov settings to increase the allowed drop? |
In the past, for cases like this, we've just forced the merge. I like keeping the codecov settings like they are so that drops are visible. However, I don't have the permissions to allow the merge. @tlambert03 @DragaDoncila Do you know who does? I'd love @Czaki to get permissions here. |
|
I don't understand, all napari core devs are on the team here with write access... as are you. Is it an admin access thing? |
Just check. @tlambert03 is the only one who has such permissions, but any person with admin access to napari organization could add the next such persons.
yes |
|
@Czaki Just gave you admin |
|
@nclack The whole idea is to reenable it within a week but to allow current PR work. |
In this PR I have disabled the test depending on
example-pluginpython package as it was hidden by the creator.