feat(napi) Implement Either3 to Either26.
#1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Hywan
force-pushed
the
feat-either-n-up-to-26
branch
3 times, most recently
from
5c5c6ec
to
ade6ea8
Compare
|
@Hywan Thank you, but it needs some more refactor on |
|
Feel free to iterate on this PR :-). |
This patch introduces a new macro: `either_n!` that generates the types
`Either{n}` where $3 \leq n \leq 26$. Manual implementations for
`Either3`, `Either4` and `Either5` are removed by this patch too.
The `either_n!` macro is quite classical. There is no particular
trick, except `count_idents!` which simply turns, e.g. `A, B, C` into
`3`. This macro is used by `either_n!` to implement the
`debug_assert!` inside `from_napi_value`.
Brooooooklyn
force-pushed
the
feat-either-n-up-to-26
branch
from
ade6ea8
to
53cab27
Compare
Brooooooklyn
changed the title
Either3 to Either26.Either3 to Either26.
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Jul 7, 2022
…ning `Uint8Array`. The new `napi-rs` release includes a patch that avoids cloning and copying data inside a `Uint8Array` (napi-rs/napi-rs#1224), it now returns a “Node.js reference” of it. This new `napi-rs` release also includes one of our patch, napi-rs/napi-rs#1200, which means we no longer need to depend on our fork.
jplatte
pushed a commit
to matrix-org/matrix-rust-sdk-crypto-nodejs
that referenced
this pull request
Jul 12, 2023
…ning `Uint8Array`. The new `napi-rs` release includes a patch that avoids cloning and copying data inside a `Uint8Array` (napi-rs/napi-rs#1224), it now returns a “Node.js reference” of it. This new `napi-rs` release also includes one of our patch, napi-rs/napi-rs#1200, which means we no longer need to depend on our fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new macro:
$3 \leq n \leq 26$ . Manual implementations for
either_n!that generates the typesEither{n}whereEither3,Either4andEither5are removed by this patch too.The
either_n!macro is quite classical. There is no particulartrick, except
count_idents!which simply turns, e.g.A, B, Cinto3. This macro is used byeither_n!to implement thedebug_assert!insidefrom_napi_value.