Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue: Error in pip install #70 #71

Merged
merged 2 commits into from
Apr 21, 2017

Conversation

norecces
Copy link
Contributor

issue #70

@napjon
Copy link
Owner

napjon commented Apr 20, 2017

Oh wow, what is it the character that technically caused the error? :)

All of this are running great, I see it can render all the notebooks. But it still failed the unit tests. I see only the last script, test_tooltip.py. Could you also fix that?

You can create the unit test environment by doing the following,

pip install coverage pytest
git clone https://github.com/norecces/krisk
git checkout fix_pip_install_27
cd krisk
coverage run --source krisk -m py.test

I will also update the README.md to add the development mode, and python 2.7 in the CircleCI.

@norecces
Copy link
Contributor Author

Oh wow, what is it the character that technically caused the error? :)

yeap, that's it

All of this are running great, I see it can render all the notebooks. But it still failed the unit tests. I see only the last script, test_tooltip.py. Could you also fix that?

done

thanks for nice lib !

Copy link
Owner

@napjon napjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@napjon napjon merged commit d37c4ef into napjon:master Apr 21, 2017
@napjon
Copy link
Owner

napjon commented Apr 21, 2017

Merging. Thank you for contributing!

@napjon napjon mentioned this pull request Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants