-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align stimulus function (first) #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First working version of the align_stimulus_to_recording function in the naplib.naplab module
Simplified alignment by removing arguments initially added to improve efficiency (not needed with cross-correlation method), and improved doc string
Added test data, test function, and file to generate docs
gavinmischler
approved these changes
Mar 31, 2023
t_start_look : float, default=0 | ||
What time of the recorded audio to begin the searching process | ||
By default, uses 0 seconds, i.e. beginning of recorded audio | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no docstring for verbose
|
||
# Determine which stimulus channel was best, set useCh, save inds | ||
if useCh == None: | ||
print(f'Using channel {np.argmax(max_corrs)}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only print if verbose
Adding docstring for verbose and only doing any prints if verbose=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working version of the align_stimulus_to_recording function in the naplib.naplab module
Reference Issues/PRs
Fixes #116 Function to perform alignment for iEEG pipeline
What does this implement/fix? Explain your changes.
Adds a function to perform alignment between the audio recorded during an experiment with the stimulus files played during the experiment
Any other comments?