Major memory usage optimization in iEEG pipeline #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+241
to
+242
| raw_data['data'] = raw_data['data'][earliest_sample:latest_sample].copy() | ||
| raw_data['wav'] = raw_data['wav'][earliest_sample:latest_sample].copy() |
There was a problem hiding this comment.
Why do you copy these here?
There was a problem hiding this comment.
This was a part of the memory optimization. Returning a slice of the numpy array keeps the entire array alive in memory. Copying momentarily increases memory usage, but then drops the larger array and only keeps the smaller one. I couldn't find a way to discard the unwanted parts without making a copy.
| @@ -161,23 +160,30 @@ def filterbank_hilbert(x, fs, Wn=[1,150], n_jobs=-1): | |||
|
|
|||
There was a problem hiding this comment.
Unless you add a parameter like return_average and set it to False by default, the above Examples section is now broken
There was a problem hiding this comment.
Separated this functionality into two functions now: filter_hilbert and filterbank_hilbert
gavinmischler
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?