Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/PG-1032 refactor application #6

Merged
merged 8 commits into from
Sep 2, 2022

Conversation

Carmendelope
Copy link
Contributor

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README/documentation, if necessary

What does this PR do?

  • Allow more than one oam application in a catalog application
  • ToYAML returns the applications and other entities in YAML format
  • Add NewApplicationFromTGZ

Where should the reviewer start?

What is missing?

How should this be manually tested?

Any background context you want to provide?

What are the associated tickets?

Screenshots (if appropriate)

Questions

Copy link

@dhiguero dhiguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Carmendelope Carmendelope merged commit cc2f567 into main Sep 2, 2022
@Carmendelope Carmendelope deleted the feature/PG-1032_refactor_application branch September 2, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants