Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG-1069 Enable processing sub-directories from a given path #20

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

dhiguero
Copy link
Contributor

@dhiguero dhiguero commented Feb 14, 2023

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README/documentation, if necessary

What does this PR do?

  • Enable RDBMS load jobs to be given a directory, and load all files found in the different sub-directories recursively. The functionality is backward-compatible as it uses the same parameters but detects if it is a directory or a file.
  • Improve overall operation logging
  • Add a new parameter to look for a specific file extension

Where should the reviewer start?

What is missing?

How should this be manually tested?

        cmd:
          - "./rdbms"
          - "schema"
          - "load"
          - "--scriptLoadPath=/napptive/config/"
          - "-c=host=postgres port=5432 user=$(POSTGRES_USER) password=$(POSTGRES_PASSWORD) dbname=$(POSTGRES_DB)"

Any background context you want to provide?

  • When executing a load job for development purposes it is more convenient to use a single trait to mount the configmaps.

What are the associated tickets?

  • PG-1069

Screenshots (if appropriate)

Questions

Copy link
Contributor

@Carmendelope Carmendelope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@dhiguero dhiguero merged commit 57df116 into main Feb 15, 2023
@dhiguero dhiguero deleted the feature/PG-1069_multiple_files branch February 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants