activetab to profile #1000
Merged
activetab to profile #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@narayan954 review it. |
|
congratulations on doing the 1000th contribution on this project!! :) |
narayan954
requested changes
Jul 27, 2023
| @@ -44,7 +44,6 @@ | |||
| --emoji-btn: rgb(240, 240, 123); | |||
| --profile-container: rgb(50, 48, 48); | |||
| --profile-box-shadow: 0 0 6px white; | |||
| --profile-divider: #898989; | |||
There was a problem hiding this comment.
you just removed the variable and that too for dark mode only, that's not recommended, you're just breaking the css there. You should've dealt with the occurrence as well, if it was being used anywhere else, it could've broken that as well.
There was a problem hiding this comment.
There's another occurrence of this variable in line 16 for light mode.
Also, this was being used in the divider element in profile page, so it was better to remove that divider instead. I'm fixing these, but please take care of this from next time
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #995
close #995
set the activetab class to profile in sidebar and also remove horizontal line.
