Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed react deploy #110

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fixed react deploy #110

merged 1 commit into from
Dec 7, 2022

Conversation

ansharora28
Copy link
Contributor

enabling build and deploy in vite.config.js, the repo is functioning now in github pages in my forked repo:

https://ansharora28.github.io/dummygram/

Issue#3
image

github-actions[bot]
github-actions bot reviewed Dec 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@narayan954 narayan954 merged commit a9c82d8 into narayan954:master Dec 7, 2022
@narayan954 narayan954 mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansharora28 @narayan954