Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replaced WebP File Format with instead of using jpg, png Files Format in Suitable Files #1186

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

NarendraKoya999
Copy link
Contributor

@NarendraKoya999 NarendraKoya999 commented Aug 7, 2023

GSSOC'23 Contributor

Fixes Issue No : #1168

Proposed Changes

  • Replaced webp Images File Format with intead of using jpg, png File Format in Full Project Directory even in Codebase Files also.

For Reviewers

  • I cross checked Every Minude Details 2 to 3 Times after My Changes Made.
  • So, I hope In my Side, No Mistakes Happened. If any unwanted Mistakes in Respective Project Directory, then Please Quote Me.
  • One Suggestion to You, Some Project related Files have Unused Images Files Imported in Multiple Files. Also, Most of the Files are not Used in Most of the Files. But, Existed those Files in Assets Section. This effects due to Unnecessary Data Consuming.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you NarendraKoya999! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@NarendraKoya999
Copy link
Contributor Author

Hi @narayan954 . Please Review on this PR as soon as Possible. Also, add Valid Level Label under GSSOC'23. Because of I have involved Full Project Directory. Thank You !

@narayan954
Copy link
Owner

narayan954 commented Aug 7, 2023

GSSOC'23 Contributor

Fixes Issue No : #1168

Proposed Changes

  • Replaced webp Images File Format with intead of using jpg, png File Format in Full Project Directory even in Codebase Files also.

For Reviewers

  • I cross checked Every Minude Details 2 to 3 Times after My Changes Made.
  • So, I hope In my Side, No Mistakes Happened. If any unwanted Mistakes in Respective Project Directory, then Please Quote Me.
  • One Suggestion to You, Some Project related Files have Unused Images Files Imported in Multiple Files. Also, Most of the Files are not Used in Most of the Files. But, Existed those Files in Assets Section. This effects due to Unnecessary Data Consuming.

Hi @NarendraKoya999 thanks a lot for fixing them. By the way as you're saying there're many unused imports as well, can you remove them as well? As you've gone through the code and know those occurrence, it'd be best if you remove them :). I'll upgrade this issue to level 2 then.

@narayan954 narayan954 linked an issue Aug 7, 2023 that may be closed by this pull request
4 tasks
@NarendraKoya999
Copy link
Contributor Author

NarendraKoya999 commented Aug 7, 2023

@narayan954 .I will go with your arguments.But, You can add Leve 2 Label after these changes.Actually, the Issue sentence is easy.Suppose any typo mistake happens,then Total Page UI appeared in different Way.So, Please think advancing with regards of considered Level Label .Thank You! 😊

@NarendraKoya999
Copy link
Contributor Author

Hi @narayan954 . I Deleted Unused Import Statements in Multiple Files. Please Review on that. If all is Ok. Without Late, Please Merged with Valid Level Label. Thank You !

@narayan954
Copy link
Owner

Hi @narayan954 . I Deleted Unused Import Statements in Multiple Files. Please Review on that. If all is Ok. Without Late, Please Merged with Valid Level Label. Thank You !

There're syntax errors, you didn't test your changes at all, I'm fixing them

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you changed the pictures but didn't fix those imports. I've fixed most of these occurrence.

@narayan954 narayan954 added level1 and removed level2 labels Aug 8, 2023
@narayan954 narayan954 merged commit b039759 into narayan954:master Aug 8, 2023
2 of 3 checks passed
@narayan954
Copy link
Owner

GSSOC'23 Contributor

Fixes Issue No : #1168

Proposed Changes

  • Replaced webp Images File Format with intead of using jpg, png File Format in Full Project Directory even in Codebase Files also.

For Reviewers

  • I cross checked Every Minude Details 2 to 3 Times after My Changes Made.
  • So, I hope In my Side, No Mistakes Happened. If any unwanted Mistakes in Respective Project Directory, then Please Quote Me.
  • One Suggestion to You, Some Project related Files have Unused Images Files Imported in Multiple Files. Also, Most of the Files are not Used in Most of the Files. But, Existed those Files in Assets Section. This effects due to Unnecessary Data Consuming.

I doubt you checked the changes, that's why I have reduced the level label. There's a functionality called search which can quickly show all the affected occurrence and we can fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Convert png, jpg Image Files Format into WebP Format 🌟
2 participants