Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1258 signup button overflowing in mobile devices when guest user sign in #1259

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fixes #1258 signup button overflowing in mobile devices when guest user sign in #1259

merged 2 commits into from
Sep 7, 2023

Conversation

love-sonkar
Copy link
Contributor

fixes [BUG] #1258 added background color to the button so content and button don't overlap

github-actions[bot]
github-actions bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you love-sonkar! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

github-actions[bot]
github-actions bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there love-sonkar!, congratulations on your first pull request :)

@narayan954 narayan954 changed the title fixes #1258 singup button overflowing in mobile devices when user sin… fixes #1258 signup button overflowing in mobile devices when user signin Sep 7, 2023
@narayan954 narayan954 changed the title fixes #1258 signup button overflowing in mobile devices when user signin fixes #1258 signup button overflowing in mobile devices when guest user sign in Sep 7, 2023
@narayan954 narayan954 linked an issue Sep 7, 2023 that may be closed by this pull request
[BUG]: Signup button is overflowing in mobile devices when user singup as a guest user. #1258
Closed
4 tasks
narayan954
narayan954 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit f77785a into narayan954:master Sep 7, 2023
2 of 3 checks passed
@narayan954
Copy link
Owner

Thanks for your contribution! :)

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Signup button is overflowing in mobile devices when user singup as a guest user.
2 participants
@love-sonkar @narayan954