Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reloading issue, when user click refresh button it shows 404 page. #1260

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

love-sonkar
Copy link
Contributor

@love-sonkar love-sonkar commented Sep 18, 2023

fixes #1043 fixed the reloading issue when user click refresh button in middle of the page it shows 404 now it's fixed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you love-sonkar! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the extra base that was added in the URL, hoping this should work in the github pages deployment as well. Rest it looks good to me!

@narayan954
Copy link
Owner

Adding some docs for reference.
spa-routing
spa-github-pages
I'm checking if this works on github pages or not, else we can try the other approach mentioned in the docs

@narayan954 narayan954 merged commit b050394 into narayan954:master Sep 18, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<bug>: Reloading issue
2 participants