Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#367-added close button on new posts #368

Merged
merged 1 commit into from
May 28, 2023
Merged

#367-added close button on new posts #368

merged 1 commit into from
May 28, 2023

Conversation

Soulpurr
Copy link
Contributor

fixes #367
So i have added a cross on create new posts which closes the current window
scrnli_27_05_2023_23-53-33.webm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@Soulpurr
Copy link
Contributor Author

@narayansoni pls approve this pr

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

src/components/ImgUpload.jsx Outdated Show resolved Hide resolved
src/components/ImgUpload.jsx Outdated Show resolved Hide resolved
@Soulpurr
Copy link
Contributor Author

@narayan954 can you pls verify that the changes are reflected or not

@narayan954
Copy link
Owner

@narayan954 can you pls verify that the changes are reflected or not

yes all right!

@Soulpurr
Copy link
Contributor Author

Pls approve it then🥹

@narayan954
Copy link
Owner

Pls approve it then🥹

there you go!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 3c1b931 into narayan954:master May 28, 2023
@narayan954
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Close button missing on create new post
2 participants