Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 414 #428

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Issue 414 #428

merged 5 commits into from
Jun 6, 2023

Conversation

Soulpurr
Copy link
Contributor

@Soulpurr Soulpurr commented Jun 4, 2023

for larger screens more than 800 px now the card items are in row.
fixes #414
scrnli_03_06_2023_16-45-39.webm

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 4, 2023

@narayansoni pls verify and approve this .

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 5, 2023

@narayan954 can you pls check and approve this pr .

@narayan954
Copy link
Owner

for larger screens more than 800 px now the card items are in row. fixes #414 scrnli_03_06_2023_16-45-39.webm

Hi @Soulpurr I'd like to apologise but this doesn't seem right. The original implementation of unlimited scrolling in column format seems better. I'm really sorry I didn't clarify this on the issue itself.

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 5, 2023

@narayan954 ahh it's alright

@narayan954
Copy link
Owner

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

@narayan954
Copy link
Owner

narayan954 commented Jun 5, 2023

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 5, 2023

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

@narayan954
Copy link
Owner

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 5, 2023

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

@narayan954
Copy link
Owner

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

exactly

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 5, 2023

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

Actually that's a great idea,I can work on it

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

exactly

So I can work on it and make changes in this pr only?

@narayan954
Copy link
Owner

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

Actually that's a great idea,I can work on it

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

exactly

So I can work on it and make changes in this pr only?

Yes you can work on this :) and make changes however you like... Also, we'll update the issue to level 2.

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 6, 2023

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

Actually that's a great idea,I can work on it

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

exactly

So I can work on it and make changes in this pr only?

Yes you can work on this :) and make changes however you like... Also, we'll update the issue to level 2.

@narayan954 i have added that feature as requested you can check and verify and also pls increase the level of issue from 1 to 2.

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 6, 2023

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

Actually that's a great idea,I can work on it

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

exactly

So I can work on it and make changes in this pr only?

Yes you can work on this :) and make changes however you like... Also, we'll update the issue to level 2.

@narayan954 i have added that feature as requested you can check and verify and also pls increase the level of issue from 1 to 2.

scrnli_06_06_2023_18-13-02.webm

@narayan954
Copy link
Owner

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

Actually that's a great idea,I can work on it

@narayan954 ahh it's alright

@Soulpurr I thought of something... how about we add a trigger/button to change the alignment for bigger screens???

so users can view these posts as they wish. This'd be a unique feature for our app as well

Like what on clicking a button the alignment changes from column to row or you want to load more post on clicking a button?

just like in some apps where we can switch/toggle between row display or column display. A small trigger icon button at top right corner beneath the navbar.

Like on clicking that button the alignment changes from col to row or vica versa.Just like a theme toggling button right?

exactly

So I can work on it and make changes in this pr only?

Yes you can work on this :) and make changes however you like... Also, we'll update the issue to level 2.

@narayan954 i have added that feature as requested you can check and verify and also pls increase the level of issue from 1 to 2.

Great, done... reviewing this!

@narayan954
Copy link
Owner

It's not responsive for small screens... can you check??
image

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 6, 2023

It's not responsive for small screens... can you check?? image

Uhh let me just fix that btw any more changes so that I can fix them all at once

@Soulpurr
Copy link
Contributor Author

Soulpurr commented Jun 6, 2023

It's not responsive for small screens... can you check?? image

@narayan954 verify it if its fixed or not.

@narayan954
Copy link
Owner

It's not responsive for small screens... can you check?? image

@narayan954 verify it if its fixed or not.

yes it's fixed... reviewing this

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 416cb32 into narayan954:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Post items should be in row
2 participants