Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark mode in sidebar #513

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Added dark mode in sidebar #513

merged 2 commits into from
Jun 21, 2023

Conversation

sumitkr2000
Copy link
Contributor

@sumitkr2000 sumitkr2000 commented Jun 21, 2023

Hey @narayan954 I have added dark mode in sidebar. Please review my pr and merge it. Thank you!

Before:-

image

After:-

image

@narayan954
Copy link
Owner

Hey @narayan954 I have added dark mode in sidebar. Please review my pr and merge it. Thank you!

Before:-

image

After:-

image

I think you've linked the incorrect issue, please correct

@narayan954 narayan954 linked an issue Jun 21, 2023 that may be closed by this pull request
@narayan954
Copy link
Owner

Also, this was an assigned issue...

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narayan954 narayan954 merged commit 3eabc97 into narayan954:master Jun 21, 2023
@sumitkr2000
Copy link
Contributor Author

Also, this was an assigned issue...

Ohh sorry...i thought i told you when i created sidebar...that i will add dark mode in another pr... that's why i did it.

@narayan954
Copy link
Owner

Also, this was an assigned issue...

Ohh sorry...i thought i told you when i created sidebar...that i will add dark mode in another pr... that's why i did it.

yeah, that was a different issue and he raised and claimed it. It's okay this time but make sure to claim it next time.

@sumitkr2000
Copy link
Contributor Author

Okay bro thanks

@sumitkr2000 sumitkr2000 deleted the darkmode branch June 22, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Darkmode not applicable on sidebar
2 participants