Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement footer in sidebar #554

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #542
A simple footer for sidebar.
I was not able to think of anything else to put. I think you should take a MIT license for dummygram. If you want you can make this issue of level 1

@narayan954
Copy link
Owner

This PR closes issue no. #542 A simple footer for sidebar. I was not able to think of anything else to put. I think you should take a MIT license for dummygram. If you want you can make this issue of level 1

there's already MIT license for Dummygram

@narayan954 narayan954 linked an issue Jun 25, 2023 that may be closed by this pull request
@narayan954
Copy link
Owner

Hi @Palakkgoyal , after updating the pull request to the current version of master, css is breaking, can you try to fix that...
Ps: some classes are conflicting after the code refactoring we performed

@Palakkgoyal
Copy link
Contributor Author

Ohk sure. I will fix that.

@Palakkgoyal
Copy link
Contributor Author

I have resolved the bug. Please check.

@narayan954
Copy link
Owner

I have resolved the bug. Please check.

Sure!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 1a3d275 into narayan954:master Jun 27, 2023
@Palakkgoyal Palakkgoyal deleted the sidebarFooter branch June 30, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement a footer in the sidebar
2 participants