Implemented dark mode #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved postview page (narayan954#583) * "fixed: changes to post-view page and image slider" * "changes to post-view" * "changes to post-view" * “fixed: issues with view of comments in different screens” * format code --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> working on darkmode fix visibility of post caption that don't have images
narayan954
requested changes
Jun 30, 2023
There was a problem hiding this comment.
You did really good, but some of the styles are missing such as the shadow effects on logout modal
Signup and signin pages have also lost their cover
Also, I've applied background color from github dark mode
Is that okay??
Please fix those lost styles and I can update the difficulty level of this issue :)
|
Yes, sure. I will do the required changes. |
|
Did all the changes. Please review them |
|
@narayan954 Dont give level3 tags to such basic work. it is atmost level2 |
it's level 2 only, might've assigned level2 by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue no. #541
